celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

nodebuilder/node: `Init` should also generate and save node ID and JWT secret

Open renaynay opened this issue 1 year ago • 6 comments

Init initialises the node directory, but is still missing some components:

  • Node ID
  • JWT secret

Users should be able to run celestia <node_type> init and for all keys to be present such that they can

  • know their own peerID
  • generate jwt tokens before the node is started.

cc @cmwaters

renaynay avatar Nov 20 '24 12:11 renaynay

Or we should remove init altogther in favor of lazy init from start

Wondertan avatar Nov 20 '24 13:11 Wondertan

I would prefer not to remove it before doing a bit of research with node operators to see how many actually prefer the initialisation step to be separate.

renaynay avatar Nov 20 '24 17:11 renaynay

@renaynay @Wondertan Hi! I opened a PR (#4232) that adds Node ID and JWT secret generation as suggested here. Let me know if there’s anything missing or that needs adjustment. Thanks!

Himess avatar Apr 22 '25 14:04 Himess

Or we should remove init altogther in favor of lazy init from start

That can be done as a separate issue.

We should make sure that the user has access to this data and isn't just a one-off

cmwaters avatar Apr 24 '25 09:04 cmwaters

@cmwaters wdym by "We should make sure that the user has access to this data and isn't just a one-off"

renaynay avatar Apr 24 '25 11:04 renaynay

Just that we should store the node id and jwt secret

cmwaters avatar Apr 24 '25 12:04 cmwaters