celestia-node
celestia-node copied to clipboard
break: drop `module.GetShare` at some point
Implementation ideas
Based on comment https://github.com/celestiaorg/celestia-node/pull/3891#discussion_r1849677926
CC: @Wondertan
Notes from call:
- This isn't just a deprecate + remove. It's a new method.
GetSamplesaccepts different arguments and returns different values.GetSamplesreturns proofs.- Do users use
GetShare?- Can we get metrics on usage? We have some indirect metrics that we can collect.
- Can we get signal from Diego or RollKit? Diego already shared which endpoints are used. See doc.
GetShareisn't really used.
- Another method exists:
GetRangesoGetSharemay not be used much.