celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

bug: bitswap log severity as ERROR is confusing for users

Open jcstein opened this issue 1 year ago • 2 comments

When running light node on v0.18.2-mocha, I observe a flood of logs:

2024-10-08T14:38:50.290-0400	ERROR	shwap/bitswap	bitswap/block_fetch.go:190hasher: no unmarshallers registered for bagipaamr6aaqyaaaaaaaak6uuyaauaaq

While the log can be ignored and is non-critical, it is confusing and worrisome to users who see "ERROR" repeatedly in their logs.

The error message should say "INFO" if this is not in fact an "ERROR"

https://github.com/user-attachments/assets/ced9c237-5988-41dd-809e-02ec10c1bc54

jcstein avatar Oct 21 '24 13:10 jcstein

The good news are. I've been running a version of node over the weekend with none of those logs addressing the root issue. We can expect it to come around next week.

Wondertan avatar Oct 21 '24 14:10 Wondertan

There are duplicate messages being requested and every duplicate spawns a log.

Wondertan avatar Oct 21 '24 14:10 Wondertan

Hello,

I'd love to help out with this issue if it's still up for grabs. It looks like the log level should just be adjusted from "ERROR" to "INFO" to avoid spooking users with non-critical messages.

Happy to work on it and follow any contribution guidelines. Let me know if I can pick this up!

amosehiguese avatar Feb 10 '25 11:02 amosehiguese