celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

makefile: Report correct tag in binary version

Open Wondertan opened this issue 1 year ago • 1 comments

If there are several tags on the same commit(like -arabica and -mocha) it will always give the latest tag, even if you do git checkout tags/<tag> on a specific tag.

It's unclear to me right now how to solve that. One of the options is to ensure different tags are never on the same commit, but there might be an easier way.

Wondertan avatar Oct 07 '24 10:10 Wondertan

I don't expect this to work in 100% of cases but I think it's an improvement over the current buggy version reporting: https://github.com/celestiaorg/celestia-app/pull/3977

rootulp avatar Oct 15 '24 19:10 rootulp

When #4230 merges , we can close this issue i think.

Himess avatar Apr 30 '25 13:04 Himess