celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

v0.16.0 release doesn't have prebuilt binaries

Open rootulp opened this issue 1 year ago • 7 comments

Context

https://github.com/celestiaorg/celestia-node/releases/tag/v0.16.0 doesn't have prebuilt binaries.

Problem

Looks like integration tests keep failing on https://github.com/celestiaorg/celestia-node/actions/runs/10685447212 so version_bump and goreleaser never get triggered

Proposal

  1. [short term] keep retrying CI until it succeeds
  2. [medium term] maybe make version bump not depend on integration tests b/c they're flaky
  3. [long term] fix the flaky integration tests

An alternative short term solution is to manually attach the prebuilt binaries. We've had to do that a lot on celestia-app b/c goreleaser config issues so we have a guide.

rootulp avatar Sep 04 '24 15:09 rootulp

Should be fixed now @rootulp

renaynay avatar Sep 10 '24 11:09 renaynay

https://github.com/celestiaorg/celestia-node/releases/tag/v0.16.0

Screenshot 2024-09-10 at 2 01 22 PM

rootulp avatar Sep 10 '24 12:09 rootulp

Oh whoops sorry I thought our CI ran properly 😬

renaynay avatar Sep 10 '24 12:09 renaynay

How is this issue going now? Still have trouble in downloading prebuilt binaries with bash -c "$(curl -sL https://docs.celestia.org/celestia-node.sh)"

--2024-10-03 02:49:34--  https://github.com/celestiaorg/celestia-node/releases/download/v0.16.0/celestia-node_Linux_x86_64.tar.gz
Resolving github.com (github.com)... 140.82.114.3
Connecting to github.com (github.com)|140.82.114.3|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2024-10-03 02:49:34 ERROR 404: Not Found.

Halimao avatar Oct 03 '24 02:10 Halimao

v0.17.1 doesn't either

jcstein avatar Oct 16 '24 18:10 jcstein

Reported from devrel telegram chat:

"and the doc says testnet is celestia-node v0.18.2-mocha, but that version docker image not exists"

jcstein avatar Oct 22 '24 13:10 jcstein

Yes, I need the docker image :)

hyacinthus avatar Oct 22 '24 15:10 hyacinthus

Our CI (goreleaser) has been fixed on recent releases, and v0.16.0 is now outdated on both arabica and mocha and will become outdated tomorrow on mainnet as well.

renaynay avatar Nov 19 '24 13:11 renaynay

FYI a release from yesterday doesn't have prebuilt binaries: https://github.com/celestiaorg/celestia-node/releases/tag/v0.20.2-arabica.

Screenshot 2024-11-19 at 10 17 38 AM

GoReleaser gets confused when fetching the latest tag for a particular commit if one commit has multiple tags (i.e. v2.0.0-mocha, v2.0.0-arabica). To temporarily workaround, celestia-app plans on creating releases on distinct commits. But it looks like celestia-node had a different problem for the v0.20.2-arabica b/c GoReleaser job was skipped: https://github.com/celestiaorg/celestia-node/actions/runs/11894453531/job/33141724905

rootulp avatar Nov 19 '24 15:11 rootulp

That's interesting, thanks for the info! I will take a look tomorrow.

cristaloleg avatar Nov 19 '24 22:11 cristaloleg

is this related to #3938 ?

jcstein avatar Nov 20 '24 03:11 jcstein