celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

feat(nodebuilder/state | state): `CoreAccessor` takes a list of key names instead of just one

Open renaynay opened this issue 9 months ago • 0 comments

As part of https://github.com/celestiaorg/celestia-node/issues/3295, the node must be able to feed several keys into the CoreAccessor instead of just one as it does now.

TODO:

  • [ ] --keyring.accname takes a list instead of just one name, the default key will be the 1st key specified in the list to keep backwards compat. If no key is specified, behaviour of using my_celes_key remains.
  • [ ] KeyringSigner constructor checks to make sure all keys from keyring.accname are present in the keystore, otherwise throw error on construction. Construct keyring with all given keys.
  • [ ] CoreAccessor still takes one keyName in c-tor (that is the default key) - uses it for addr (basically do not change how this works here, just make sure the keyName that's passed in is the default key.
  • [ ] apptypes.Signer is constructed using the given keyring that contains all keys with an option that specifies the default key as the default key in the Signer c-tor as an option
  • [ ] TODO @cmwaters need the method sig at least and understanding of how default key would be specified during signer construction - SubmitPayForBlobWithOptions method use signer's option to submit a blob from a specific key name, default method (SubmtiPayForBlob) would just submit from default key

renaynay avatar May 01 '24 14:05 renaynay