celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

cel-key/rpc: Consider changing UX around `--home` `--keyring-dir` and node type / network flags as they all conflict

Open Bidon15 opened this issue 1 year ago • 3 comments

Celestia Node version

v0.13.1

OS

osx

Install tools

No response

Others

No response

Steps to reproduce it

image

Expected result

same addresses from cel-key and rpc cli calls

Actual result

not same addresses from cel-key and rpc cli call

Relevant log output

No response

Notes

No response

Bidon15 avatar Mar 18 '24 10:03 Bidon15

@Bidon15 are you using celestia-node keyring utility or app's? Where does this utility live? I cannot reproduce this issue, so I would check the binary you are using for cel-key.

renaynay avatar Mar 20 '24 14:03 renaynay

Aha - reproduced it

using --home won't take effect if --node.type is provided as --node.type flag overrides home dir and looks for the default celestia directory when no network is provided which is mainnet (~/.celestia-light)

Use --keyring-dir ~/.celestia-light-mocha-4/keys instead of --home and that will fix the issue.

We do need to improve keyring directory identification for cel-key though, it's currently all over the place. Apologies for the jankyness.

renaynay avatar Mar 20 '24 14:03 renaynay

Repurposing this issue to change UX around directory determination in cel-key

renaynay avatar Mar 21 '24 15:03 renaynay