celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

feat(discovery): add jitter and fix backoff

Open nodersteam opened this issue 2 years ago • 4 comments

  • Replacing time.NewTicker with time.NewTimer
  • Adding backoff logic
  • Adding jitter to backoff
  • Removed unused test variable

nodersteam avatar Nov 27 '23 15:11 nodersteam

Is it acceptable to use math/rand or add generation logic via crypto/rand to fix Lint?

nodersteam avatar Nov 28 '23 12:11 nodersteam

@Wondertan Could you please check this PR? Or is it possible to point out more important issues at the moment if this PR is not of value at the moment?

nodersteam avatar Dec 13 '23 15:12 nodersteam

Hey @nodersteam, I am deferring the review of this to @walldiss, as the most prominent expert on that code.

Wondertan avatar Dec 15 '23 14:12 Wondertan

Hey @nodersteam, I am deferring the review of this to @walldiss, as the most prominent expert on that code.

Got it! Thx

nodersteam avatar Dec 18 '23 06:12 nodersteam