celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard
verified publisher icon celestiaorg

share.SharesAvailable can not be called from other JSON RPC frameworks due to a bug in go-jsonrpc

Open oblique opened this issue 2 years ago • 4 comments

Celestia Node version

eaa58358b21f9ffbb580de48071e2315e55a2b9c

OS

Linux

Install tools

No response

Others

No response

Steps to reproduce it

Call share.SharesAvailable form JSON RPC clients other than go-jsonrpc. In our case we used jsonrpsee.

Expected result

A response that has result or error field.

Actual result

Server responds with {"jsonrpc":"2.0","id":1}, which is causing deserialization issues on the client side.

Relevant log output

No response

Notes

This is a bug in go-jsonrpc, but reported too here for tracking. Check https://github.com/filecoin-project/go-jsonrpc/issues/102

oblique avatar Jul 12 '23 07:07 oblique

@oblique is this the case?

Wondertan avatar Sep 22 '23 14:09 Wondertan

If you ask if it's related to https://github.com/filecoin-project/go-jsonrpc/pull/103, then yes

oblique avatar Sep 22 '23 15:09 oblique

@Wondertan go-jsonrpc just merged a fix for this, I think this can be closed after updating dependencies

zvolin avatar May 08 '24 11:05 zvolin

https://github.com/filecoin-project/go-jsonrpc/issues/102#event-12741125149

zvolin avatar May 08 '24 11:05 zvolin