celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

refactor(getters/shrex): construct peer manager inside shrex-getter

Open distractedm1nd opened this issue 2 years ago • 1 comments

          If ShrexGetter maintains the lifecycle of `peer.Manager`, it should also construct it, i.e. `peer.Manager` is a child of ShrexGetter but not a dependency. This also means that peer manager won't be part of FX dep graph, which is totally ok as the peer manager is singly purposed.

Originally posted by @Wondertan in https://github.com/celestiaorg/celestia-node/pull/1743#discussion_r1105906346

distractedm1nd avatar Feb 16 '23 09:02 distractedm1nd

@renaynay Please add more details on impl details

walldiss avatar Jun 26 '25 12:06 walldiss