celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

Published 20 hours ago • verified publisher icon celestiaorg

nodebuilder: Rename sub-pkgs to `<subpkg>_constructor` to differentiate from root-level pkgs

Open renaynay opened this issue 3 years ago • 5 comments

So instead of it being

nodebuilder/state, it should be nodebuilder/state_constructor

renaynay avatar Nov 03 '22 19:11 renaynay

For the same reason, we should change the namings. These are modules, not the constructors.

Wondertan avatar Nov 08 '22 11:11 Wondertan

May I work on this? @renaynay @Wondertan So now it will be _module?

jpserrat avatar Feb 07 '23 20:02 jpserrat

We haven't found a consensus within a team on this yet, so I would punt this for a while.

Alternatively, we can quickly go with my following proposal if @renaynay and @distractedm1nd agree in this thread. I propose prepending each subpkg name in nodebuilder pkg with a mod prefix, so fraud would be modfraud.

Wondertan avatar Feb 07 '23 20:02 Wondertan

@Wondertan @ramin @renaynay Can I work on this one? I am really looking forward to consistent contributions.

saudch007 avatar Nov 25 '23 16:11 saudch007

I am find with mod prefix for the subpkg names.

Sorry for the delay on responding @saudch007 , of course feel free to work on this issue. Thank you

renaynay avatar Feb 21 '24 10:02 renaynay