celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

feat(gateway): reenabling gateway, adding flag to enable

Open distractedm1nd opened this issue 2 years ago • 2 comments

This PR is based on #1195 . It adds the gateway back onto the node (closes #1182) with it's own config, disabled by default, which is activated by the flag --gateway (closes #1183).

distractedm1nd avatar Oct 05 '22 06:10 distractedm1nd

Codecov Report

Merging #1199 (f70ca3b) into main (cb92051) will increase coverage by 0.29%. The diff coverage is 54.42%.

:exclamation: Current head f70ca3b differs from pull request most recent head cb941ac. Consider uploading reports for the commit cb941ac to get more accurate results

@@            Coverage Diff             @@
##             main    #1199      +/-   ##
==========================================
+ Coverage   55.56%   55.85%   +0.29%     
==========================================
  Files         162      168       +6     
  Lines        9981    10167     +186     
==========================================
+ Hits         5546     5679     +133     
- Misses       3881     3924      +43     
- Partials      554      564      +10     
Impacted Files Coverage Δ
nodebuilder/gateway/gateway.go 0.00% <0.00%> (ø)
nodebuilder/module.go 100.00% <ø> (ø)
nodebuilder/node.go 60.31% <ø> (ø)
nodebuilder/gateway/module.go 15.78% <15.78%> (ø)
api/gateway/server.go 66.66% <58.82%> (-2.23%) :arrow_down:
nodebuilder/gateway/config.go 62.50% <62.50%> (ø)
cmd/celestia/full.go 38.02% <66.66%> (+1.26%) :arrow_up:
cmd/celestia/light.go 37.50% <66.66%> (+1.26%) :arrow_up:
api/rpc/server.go 75.00% <70.58%> (-7.15%) :arrow_down:
nodebuilder/gateway/flags.go 75.67% <75.67%> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 05 '22 06:10 codecov-commenter

Converted to draft, only because the PR it is based on is also in draft

distractedm1nd avatar Oct 06 '22 15:10 distractedm1nd