celestiaorg
chore!: make the row proof range end exclusive
Description
Closes https://github.com/celestiaorg/celestia-core/issues/1375
It would be nice if we could cram this change also in v2. If not, then once this change makes it to a release, we need to remember to update the app implementation and any downstream repo to use end exclusive ranges for row proofs. Would creating an issue work?
PR checklist
- [x] Tests written/updated
- [ ] Changelog entry added in
.changelog(we use unclog to manage our changelog) - [ ] Updated relevant documentation (
docs/orspec/) and code comments
This is a breaking change right? I'm not sure if we've agreed on branch management / releases for celestia-core yet
[thinking out loud]
Why not have a v0.34.x-v2 branch that contains the breaking changes. This branch should only contain the changes that are on main and we want to include in v2.
The existing branch v0.34.x could be renamed to v0.34.x-v1 to reflect that this is the verison used for V1.
[thinking out loud] Why not have a
v0.34.x-v2branch that contains the breaking changes. This branch should only contain the changes that are on main and we want to include in v2. The existing branchv0.34.xcould be renamed tov0.34.x-v1to reflect that this is the verison used for V1.
The problem is a little more complex then that given our current upgrading strategy. We could be running v2 binary on a v1 network, thus celestia-core also needs to be wary of the app version
Why not have a v0.34.x-v2 branch that contains the breaking changes.
celestia-app v2 won't use any celestia-core breaking changes that aren't present in celestia-core v1.36.1-tm-v0.34.29 because celestia-app v2.0.0-rc1 is being audited and it depends on v1.36.1-tm-v0.34.29.
are these proofs moved elsewhere for node @rach-id ? if so, can we close this and remove them here?
Once we release the proofs in node. I will start deprecating the endpoints. But for the proofs implementation, it will remain in core because it's used in tx proof. So we still need this PR to be part of v3 if possible.
defer to you @rach-id if you still want to include this change in v4 or v5 etc
this was supposed to go out when the solutions team were working on this. But I guess now if we make this change, we might need to update also downstream repos that use this, not just celestia-app. So I guess we can leave it the way it is unless some pressing need comes up.