celestia-app

celestia-app copied to clipboard

## Context https://celestiaorg.github.io/celestia-specs/latest/specs/data_structures.html#share ## Problem There is an inconsistency between the specs and current implementation: the first share of a message includes a length delimiter. See https://github.com/celestiaorg/celestia-app/blob/main/pkg/shares/split_sparse_shares.go#L25

rootulp

We should update https://celestiaorg.github.io/celestia-specs/latest/specs/data_structures.html#share to describe the universal share encoding schema. See [this ADR](https://github.com/celestiaorg/celestia-app/pull/660) for more details.

rootulp

Upgrade to Go 1.19

3

## Problem This repo currently uses Go 1.18 ([ref](https://github.com/celestiaorg/celestia-app/blob/d53f66b67946d20af5a24487c2f79da4ebb1b171/go.mod#L3)). Go [1.19](https://go.dev/blog/go1.19) was released. The celestia-node repo has already upgraded to Go 1.19. For developers that are working across multiple Celestia...

rootulp

Define genesis params

1

## Summary We currently use the default params of most modules. We should settle on which params we want to launch with. ## Problem Definition The defaults might not be...

liamsi

## Context https://github.com/celestiaorg/celestia-app/pull/842#pullrequestreview-1139027323 ## Problem We have package-specific Godocs in [shares/doc.go](https://github.com/celestiaorg/celestia-app/blob/c9dce391bc360bb5f068f43d4eb1681a9f35b710/pkg/shares/doc.go). However, some contributors prefer to read README.md files over godocs. As a convenience to contributors, we may want to...

rootulp

Remove usage of `BroadcastModeBlock`

1

[question] should this be `flags.BroadcastMode` per https://github.com/cosmos/cosmos-sdk/blob/7781cdb3d20bc7ebac017452897ce1e6ab3903ef/client/flags/flags.go#L114 ```suggestion // should be submitted async, sync, or block (see flags.BroadcastMode). If ``` Note: `block` mode was removed in https://github.com/cosmos/cosmos-sdk/pull/12659. Since celestia-app currently...

evan-forbes

[Non Blocking][Question] Was this `QueryWithOutProof` on purpose not `QueryWithoutProof`? _Originally posted by @SweeXordious in https://github.com/celestiaorg/celestia-app/pull/866#discussion_r994013244_

evan-forbes

per the TODO in the method description introduced in #866: `TODO: perform checks (is a power of 2 and is > 2) on // the passed squaresize arg`

evan-forbes

Replace usage of `TIA` with `CLS` in downstream repos

2

## Context After we have a celestia-app release that includes https://github.com/celestiaorg/celestia-app/pull/859 we'll want to upgrade downstream repos and replace usage of `TIA` with `CLS` Ref: https://github.com/search?p=1&q=org%3Acelestiaorg+tia&type=Code ## Repos - [...

rootulp

All shares in a reserved namespace belong to one share sequence

3

### Problem https://github.com/celestiaorg/celestia-app/issues/659 introduced an info byte that contains a sequence start indicator. The indicator must be `1` for the first share in a reserved namespace and `0` for continuation...

rootulp