celestia-app icon indicating copy to clipboard operation
celestia-app copied to clipboard

Potentially increase share size

Open liamsi opened this issue 4 years ago • 3 comments

We currently set the share size (rather arbitrarily) to 256 bytes. IMO this should be increased to maybe 1KB or more. Independent of what I think there must be a rationale document for the parameter choice explaining pros/cons and why we settled on whatever value.

liamsi avatar Aug 06 '21 09:08 liamsi

To provide some additional context: since

  1. Requests with a reserved namespace ID are concatenated contiguously, and
  2. Messages are expected to be quite large, as they're supposed to be rollup blocks (i.e. transaction batches),

it makes sense to make the share size larger rather than smaller.

adlerjohn avatar Aug 07 '21 21:08 adlerjohn

The main drawback of increasing the chunk size is that it makes data availability sampling more expensive, but we should do some calculations on this.

musalbas avatar Dec 06 '21 10:12 musalbas

Related: https://github.com/celestiaorg/celestia-app/issues/711

rootulp avatar Aug 26 '22 17:08 rootulp

Closed by https://github.com/celestiaorg/celestia-app/pull/850

rootulp avatar Oct 31 '22 20:10 rootulp