celestia-app icon indicating copy to clipboard operation
celestia-app copied to clipboard

Fees: investigate and implement fee-burning

Open liamsi opened this issue 4 years ago • 4 comments

We want to implement eip-1559 style fee burning (but in the current tendermint deferred execution model).

This requires two parts:

  1. Investigate how to achieve the above using the current execution model and within the existing ABCI methods (keeping in mind that abci++ is currently being spec'ed out). This needs to be summarized in an ADR and @adlerjohn volunteered to have a look into this.
  2. Implement the fee-burning mechanism according to the above ADR in alignment with the specs.

Until then, we can probably just live with #48.

liamsi avatar Mar 16 '21 20:03 liamsi

@fedekunze has done some work on this if you didn't catch his comment in discord https://github.com/celestiaorg/lazyledger-app/issues/49

hxrts avatar Aug 13 '21 14:08 hxrts

Yeah, @fedekunze mentioned that to me but I didn't see the discord message nor the code so far. I'll check it out! Thanks for the pointer @hxrts 🙏🏼

liamsi avatar Aug 15 '21 09:08 liamsi

Yet an unpopular concern about EIP-1559 with in-depth analysis. It might be worth looking into.

Wondertan avatar Aug 17 '21 09:08 Wondertan

just for posterity: as we've discussed in other issues/channles, we cannot have fee burning until we also have immediate execution.

evan-forbes avatar May 09 '22 12:05 evan-forbes

just for posterity: as we've discussed in other issues/channles, we cannot have fee burning until we also have immediate execution.

We don't actually need immediate execution, but we do need to ensure that each transaction that has fee burning (only PFBs in our case, can be executed properly when it gets included in a block. We are already doing a lot of this due to our existing block validity rules, the only rules that we would have to add are:

  • [ ] #979
  • [ ] Signers of PFBs have enough funds to pay for the fee of their transaction
  • [ ] Enforce a minimum fee

evan-forbes avatar Jan 18 '23 14:01 evan-forbes

ref https://github.com/celestiaorg/celestia-app/issues/1971

evan-forbes avatar Jun 21 '23 16:06 evan-forbes