celery
remove pytest classes
Pytest Classes are important if we want share parametrization between tests, which is a feature we don't use in vine's tests. This is why i suggest to remove it. The goal is to remove any code that isn't needed and that clutters the code base.
Of course! The goal is to remove any code that isn't needed. This helps maintaining the project.
The reason the number of lines increasing instead of decreasing is the newlines insterted between functions (tests). Functions must have 2 lines between them, while methods should have line of difference between them.
I updated the description. Do you find it satisfactory ?
Thank you!
which is a feature we don't use in vine's tests.
Why? Pytest parametrization is actually a great feature. I’d think we want to upgrade to it, not remove it. Also, it is not restricted to classes, so I’m not sure why this change is helpful.
Take note vine isn’t so active in terms of development; there’s much more work to be done over celery and kombu if you want to contribute 🤓
Thank you for your quick response. Yes I want to contribute, but I thought that it would be a good idea to start from the bottom up rather than starting directly in celery. The most annoying thing for me in celery is not having types when I read the source code, which hinders my experience considerably while reading the code during debugging. If there is a clear plan to type the project, can you point me to it ? If there isn't, I suggest we make one and start working on it for the next releases