If we don't want timeouts we must set the socket's timeout to None

Open thedrow opened this issue 6 years ago • 3 comments

See https://docs.python.org/3/library/socket.html#socket.socket.settimeout.

This commit was triggered by https://github.com/celery/celery/issues/4876#issuecomment-502922066. It could fix the issue as well.

Jun 21 '19 07:06 thedrow

With this change, the integration tests hang on Travis.

@matusvalo Any idea why?

Jun 22 '19 12:06 thedrow

@thedrow, see my comments in the patch. The problem is that when you are using publisher confirm, the publisher checks before publishing if broker sent a message to him. This relies on timeout=0 which this patch has changed semantics to block forever.

Jul 01 '19 14:07 matusvalo

So what should we do to fix this issue exactly?

Jul 02 '19 13:07 thedrow