django-celery-beat icon indicating copy to clipboard operation
django-celery-beat copied to clipboard

added sphinxcontrib-django to extensions

Open mfosterw opened this issue 1 year ago • 3 comments

Closes #735. To test this, first install the new dependency with pip install requirements/docs.txt and then build the docs normally.

mfosterw avatar Feb 20 '24 23:02 mfosterw

The only problem that I see is that this dependency does not yet support Django v5 and we want to put out a release that does support Dj5. Could you please check to see if that will present problems?

cclauss avatar Feb 25 '24 16:02 cclauss

Setting the minimum version of Django to 5.0 did not cause any problems installing or running this for me, and since it's only a docs dependency I assume it shouldn't affect users directly.

mfosterw avatar Feb 26 '24 20:02 mfosterw

Thank you for this patch @mfosterw, while the former patch to this, does look informative enough, the latter shows great ease of use for developers.

That said we can only push for https://github.com/sphinx-doc/sphinxcontrib-django/pull/66 to get merged.

Once again thank you @cclauss, @mfosterw.

Good job!

50-Course avatar Feb 28 '24 23:02 50-Course