django-celery-beat icon indicating copy to clipboard operation
django-celery-beat copied to clipboard

Published 20 hours ago • verified publisher icon celery

Add support for Django 4.1

Open carlosdorneles-mb opened this issue 3 years ago • 4 comments

First, Thanks for this great project! 👍

Summary: Current django-celery-beat requires Django (>=3.2.13,<4.1) and hence doesn't install together w/ Django 4.1.

carlosdorneles-mb avatar Aug 03 '22 22:08 carlosdorneles-mb

will relax the requirement and try to push a new release

auvipy avatar Aug 04 '22 05:08 auvipy

+1

awemulya avatar Aug 05 '22 03:08 awemulya

Any updates?

Olerdrive avatar Aug 15 '22 12:08 Olerdrive

work in progress https://github.com/celery/django-celery-beat/pull/567

auvipy avatar Aug 15 '22 12:08 auvipy

I'm going to do the same on the testing front

boatcoder avatar Oct 04 '22 19:10 boatcoder

Is there still something preventing django-celery-beat from supporting Django 4.1?

Crocmagnon avatar Oct 07 '22 09:10 Crocmagnon

Django 4.1 support is merged into the master branch at #567 I believe the only thing left is a new release.

@auvipy anything I can help with for a new release?

goatwu1993 avatar Oct 11 '22 07:10 goatwu1993

Please merge #589 to allow support for Django 4.1

rbarsegi avatar Oct 11 '22 16:10 rbarsegi

@rbarsegi PR #589 is not needed as PR #567 is already merged and it supports Django 4.1. We are just waiting for the generation of a new version of the code that is in the master.

carlosdorneles-mb avatar Oct 11 '22 16:10 carlosdorneles-mb

@carlosdorneles-mb #567 only updated test requirements from what I can tell. Install requirements are still behind (see the diffs in my PR). If you try to install from master branch right now it will downgrade Django to 4.0.x.

rbarsegi avatar Oct 11 '22 16:10 rbarsegi

https://github.com/celery/django-celery-beat/pull/581 can anyone check the python 3.7 failures?

auvipy avatar Oct 12 '22 16:10 auvipy

@auvipy Upstream error by kombu & celery, caused by using importlib-metadata API which is deprecated at 5.0.0

Both libs have been fixed and merged but in 5.3.0 milestone.

https://github.com/celery/kombu/pull/1601 https://github.com/celery/celery/pull/7785

Only python < 3.8 needs importlib-metadata, which is why only python37 breaks here.

open https://github.com/celery/django-celery-beat/pull/591 to prove.

goatwu1993 avatar Oct 12 '22 18:10 goatwu1993

@auvipy please release a version for django 4.1 support, which has multiple cve fixed.

Would be glad to help if anything lack.

goatwu1993 avatar Oct 13 '22 09:10 goatwu1993

yeah going to

auvipy avatar Oct 13 '22 10:10 auvipy

yeah going to

What is the estimate release date?

utapyngo avatar Oct 18 '22 04:10 utapyngo

released https://github.com/celery/django-celery-beat/releases/tag/v2.4.0 please try and report bugs

auvipy avatar Oct 19 '22 13:10 auvipy

released https://github.com/celery/django-celery-beat/releases/tag/v2.4.0 please try and report bugs

Thanks for all that you all do! We appreciate ya!

JamesonNetworks avatar Oct 26 '22 13:10 JamesonNetworks