celery icon indicating copy to clipboard operation
celery copied to clipboard

chore(build): switch to Poetry

Open stegayet opened this issue 2 years ago • 4 comments

Note: Before submitting this pull request, please review our contributing guidelines.

Description

WIP

This is a proposal about switching from scattered build and requirements files to PEP-517 build system using poetry and poetry-core with pyproject.toml. The work is not done yet, I'd like to get some feedback about the idea first before moving forward.

TODO

  • [ ] Check that we have no regression in wheel content
  • [ ] Check that dependencies version and extras are the same as before
  • [ ] Update GH actions accordingly

stegayet avatar May 08 '23 15:05 stegayet

Hey @stegayet , thank you for taking the lead on such proposal. I had on my mind upgrading us to Poetry after 5.3 release, as the upcoming pytest-celery also uses poetry and I think it would benefit Celery as well.

That being said, it means that it will be interesting after the release which unfortunately is still delaying. Also, I believe a proper upgrade should be on more repos and not just Celery.

@thedrow @auvipy - What do you think?

Nusnus avatar May 08 '23 20:05 Nusnus

I can do the same move for other repositories related to Celery :+1: We are not in a rush, this can definitely wait after 5.3 release.

Do you have an idea when 5.3 release is going to land ?

stegayet avatar May 09 '23 00:05 stegayet

Do you have an idea when 5.3 release is going to land ?

we plan to release it in this may

auvipy avatar May 09 '23 04:05 auvipy

What about keeping setuptools and just migrating to pyproject? Poetry can be tricky w.r.t. dependencies for libraries (see this article) and things might change with https://github.com/python-poetry/poetry/pull/9135, meaning more work will have to be done once PEP 621 gets supported by Poetry.

Viicos avatar Apr 18 '24 13:04 Viicos