NameError on Pool.shrink()

[mschwoer]

On calling Pool.shrink() I get a NameError: name 'values' is not defined (version: 4.0.2).

Seems like values() has been introduced quite a while ago (https://github.com/celery/billiard/blob/88ff851b9f97fdba497e6ad7062f76265795f1af/billiard/pool.py), but the import from .five has been removed down the line.

System

• python 3.8 on MacOS 11.6.8

Steps to reproduce

conda create --name myenv python=3.8
conda activate myenv
pip install billiard==4.0.2
python

in the REPL, type

import billiard
p = billiard.Pool()
p.shrink(1)

[auvipy]

https://github.com/celery/billiard/blob/88ff851b9f97fdba497e6ad7062f76265795f1af/billiard/pool.py#L1285 this line right?

[auvipy]

yes I can reproduce it

[auvipy]

https://github.com/celery/billiard/blob/88ff851b9f97fdba497e6ad7062f76265795f1af/billiard/pool.py#L1310

[auvipy]

related https://github.com/celery/billiard/pull/374 please try the pr and let me know

[mschwoer]

LGTM