Celery-Kubernetes-Operator icon indicating copy to clipboard operation
Celery-Kubernetes-Operator copied to clipboard

Add creation handler (WIP)

Open gautamp8 opened this issue 4 years ago • 2 comments

This PR contains the following changes -

  • Add dataclass for custom resource
  • Utilities for generating Kubernetes resources(Pods, Service, Deployments) for worker and flower
  • Some refactoring/re-arranging of old project files

TODOs:

  • Decide the handler status return structure to be stored as status value in custom resource created
  • Support for Celery 5
  • Kopf unit test for creation

Dependent changes - This PR to be merged only after https://github.com/celery/Celery-Kubernetes-Operator/pull/15 is merged.

Upcoming changes:

  • Add Update handler
  • Cleaning up of old code of updation, creation, and autoscaling utilities.

gautamp8 avatar Mar 27 '21 06:03 gautamp8

This pull request introduces 2 alerts and fixes 2 when merging 14cef07fa65990c08e0be33da473ea99faff1da7 into 3163d6c30702a5f2430dcfb2dc07aa54c002803a - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'
  • 1 for Wrong number of arguments in a call

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unused import

lgtm-com[bot] avatar Mar 27 '21 07:03 lgtm-com[bot]

This pull request introduces 2 alerts and fixes 2 when merging 5565fa8e4e594b17952524e1a68fc8f64a75e7b2 into 3163d6c30702a5f2430dcfb2dc07aa54c002803a - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'
  • 1 for Wrong number of arguments in a call

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unused import

lgtm-com[bot] avatar Mar 27 '21 07:03 lgtm-com[bot]