celerity-runtime icon indicating copy to clipboard operation
celerity-runtime copied to clipboard

Buffer Debug Names

Open facuMH opened this issue 2 years ago • 3 comments

For now this only shows the buffer names plus ids instead of just ids when printing the command graph, but in a future it could also be used for instrumenting with some tracer/profiler and facilitate getting a more relevant name than just the buffer id.

Also it is the first of hopefully more debug functionalities.

facuMH avatar Aug 03 '22 12:08 facuMH

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Aug 03 '22 12:08 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Aug 04 '22 12:08 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Aug 05 '22 09:08 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Sep 05 '22 13:09 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Sep 06 '22 15:09 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Sep 07 '22 09:09 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Sep 09 '22 08:09 github-actions[bot]

A thought I just had: Right now the debug names are only really helpful when printing the graph, not when debugging a program itself (e.g. with GDB). This is because the names are not stored in the buffers themselves, but somewhere deep inside the runtime. We could however store a pointer to a std::string inside the buffer, which is returned by the buffer manager upon registration. What do you think?

psalz avatar Sep 12 '22 09:09 psalz

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Sep 15 '22 11:09 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Sep 20 '22 08:09 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Sep 20 '22 08:09 github-actions[bot]