Cee Chen

Results 307 comments of Cee Chen

Hey @dej611! I can confirm/repro this issue - I actually normally browse on Firefox with a larger `devPixelsPerPx` than the default and have def run into this in the past...

@1Copenut I don't know if this is just me but it feels like a net keyboard UX loss to have to press Enter twice now to toggle header cell actions...

Hey @tgalfin, thanks so much for the PR! Just wanted to give you a heads up that our team is currently wrapping up several large projects this week, but I'm...

@tgalfin Amazing job on this, your changes are delightfully elegant! I've made some nitty copy/test tweaks and will go ahead and merge this once CI is done running and I've...

I ended up going down a bit of a rabbit hole with this file - there was a ton of 5-7 year old code in it that needed updating and...

@Arup-Chauhan My preference would be to skip `makeHighContrastColor` and custom text color support. To be frank, it's not something I want to support in EuiBadge or EuiAvatar right now. I...

No worries at all. This isn't a high priority task, so take your time!

There isn't a need for a custom `calculateContrast` function - we already have this via our `chroma.js` library: https://github.com/elastic/eui/blob/5c4031565d1f0fef7e08e2377ea5b29bf8963b54/packages/eui/src/components/badge/color_utils.ts#L68-L70 You should be able to simply re-use the existing util and...