pyHIDS icon indicating copy to clipboard operation
pyHIDS copied to clipboard

No config file silently ignored

Open Roland0 opened this issue 1 year ago • 1 comments

Thanks for your work on pyHIDS it has inspired me.

While looking at your code (and using it) I noticed that this try block will never raise an exception as the config.read() method silently fails (by design) and returns an empty list.

I've noticed a few similar issues around the config file, I'm writing a PR (or PRs) if you're happy with that :)

Roland0 avatar Feb 11 '24 10:02 Roland0

Hi !

Indeed, it's partly intentional (and perhaps a touch of laziness on my part). I opted to let the user create their own config file using the provided example. However, I acknowledge that there's room for enhancement in this aspect. Clearly ! Therefore, I'm fully supportive of a pull request to address these improvements. :-)

Thank you !

cedricbonhomme avatar Feb 11 '24 10:02 cedricbonhomme

I close the ticket with this little change. But if you have other improvements concerning the loading of the configuration file, feel free to open a pull request.

cedricbonhomme avatar Aug 08 '24 18:08 cedricbonhomme