onestop icon indicating copy to clipboard operation
onestop copied to clipboard

Address deployment concerns on csbCrawler2Cloud

Open kenhtanaka opened this issue 4 years ago • 5 comments

Summary

As a Security officer
I want code to perform data validation to prevent SQL injection into Athena
So that I can approve csbCrawler2Cloud to run in production without vulnerabilities
  • [x] Review security report from Charlie Roberts, Identify locations for data validation
  • [x] ~Ask Charlie for clarification on issues if needed~ - not needed
  • [x] ~Update code to validate coordinates, dates, etc.~ - removed unneeded code
  • [x] Increment version number
  • [x] Create pull request
  • [x] Resubmit for security review and deployment
  • [x] Create some operations documentation
  • [ ] Deploy to on-prem prod

kenhtanaka avatar Feb 17 '21 19:02 kenhtanaka

Removed lambda_function.py and changed version number to 1.0.5.

Put in pull request https://github.com/cedardevs/csbCrawler2Cloud/pull/11

kenhtanaka avatar Feb 18 '21 20:02 kenhtanaka

Completed pull request since it was a simple change.

Tried to push a v1.0.5 to GitLab, but had a permission error (this worked about a month ago). Sent email to Richard.A.Smith, who helped with gitlab assistance in the past.

kenhtanaka avatar Feb 19 '21 01:02 kenhtanaka

Richard changed the permissions from "private" to "internal" which now allows pushing to the master branch.

Submitted WD-1314 to deploy version 1.0.5

kenhtanaka avatar Feb 19 '21 23:02 kenhtanaka

Consulting with Ernie to define a system to host the code, I started an operational guide https://docs.google.com/document/d/1IowvkadwJ2bsF__Ms5lB3DMh_SYSkFEXLM1S4vV7ba0/edit?usp=sharing

Will respond to questions as they come up.

kenhtanaka avatar Feb 25 '21 19:02 kenhtanaka

Jason says a system has been provisioned.

kenhtanaka avatar Mar 25 '21 17:03 kenhtanaka