Jared Van Bortel

Results 359 comments of Jared Van Bortel

The full contents of ` ~/Library/Logs/Homebrew/rmlint/02.scons` would be helpful, but from the part you've shown it looks like scons is unable to find gio-unix-2.0 and `gio/gunixmounts.h` is not included. What...

Build with `CFLAGS='-fsanitize=address' LDFLAGS='-fsanitize=address' scons DEBUG=1 VERBOSE=0 GDB=1` and paste the full ASAN report.

That's helpful, but the backtraces are incomplete. If you change the build command to `CFLAGS='-fsanitize=address -fno-omit-frame-pointer' ...` does the report change?

The closest I have gotten to reproducing the issue is this: ``` ERROR:lib/shredder.c:752:rm_shred_group_free: assertion failed: (self->num_pending == 0) ``` Which does not occur on the develop branch, so maybe your...

If you can't reproduce on master anymore, then running develop with `--xattr-write` must have changed the files on disk so that the issue no longer occurs. My patch cannot prevent...

Minimal reproducer: ``` $ mkdir -p repr562/a $ echo 'foo' >repr562/a/1.txt $ cp repr562/a/1.txt repr562/a/2.txt $ cp -r repr562/a repr562/b $ rmlint -o sh:/dev/null -T df,dd --write-unfinished repr562 dupped output...

`rmlint -Df` prints this message only when a symlink points outside of the traversed paths, but not in all cases. It's usually harmless. For example: ``` $ mkdir a b...

IMO, both --followlinks and --see-symlinks should be used carefully. Passing --no-followlinks by default is a good habit. --followlinks is at best a way to include files and directories you didn't...

This isn't _explicitly_ documented, but it is subtly implied by the way --progress is described in the manpage: ``` Convenience shortcut for -o progressbar -o summary -o sh:rmlint.sh -o json:rmlint.json...

For that backtrace, only thread 2 is doing anything (the others are blocked in g_cond_wait), so the next steps would be `thread 2`, `fin` and see if the open ever...