angular-highcharts icon indicating copy to clipboard operation
angular-highcharts copied to clipboard

Fix change detection

Open frct1 opened this issue 5 years ago • 4 comments

Hello, There is possible bug: when we moving cursor on graph change detection change is calling many many times

frct1 avatar Jul 17 '19 18:07 frct1

@frct1 That might just be your os/browser rendering. Every time you move your cursor an event is fired and there is an event loop that says 'where is the cursor, what is it over, what needs to change/update'. Without this event loop, there would be no way to say 'the cursor is over a point in the chart, display a tooltip' so I think that is what you're experiencing, unless you have a more detailed demo.

r-havelka avatar Sep 12 '19 15:09 r-havelka

@r-havelka No, @frct1 is correct, ALL of the highcharts events are triggering change detection, causing MASSIVE slow down. The official angular wrapper from highcharts provides an input [runOutsideAngular] to mitigate this. I have confirmed that change detection is running by profiling the code.

instantaphex avatar Nov 05 '19 19:11 instantaphex

@instantaphex Nope [runOutsideAngular] in official package doesn't help

frct1 avatar Nov 09 '19 12:11 frct1

I am facing massive slowdowns too, but it seems to happen only on Firefox. Things are fine on Edge(Chromium) and Chrome.(Latest updates as of this post)

SayakMukhopadhyay avatar Jan 20 '20 08:01 SayakMukhopadhyay