miasm icon indicating copy to clipboard operation
miasm copied to clipboard

Missing compose simplifications

Open nofiv opened this issue 4 years ago • 4 comments

Hello, I believe that expressions like ({0x46 0 8, expr_id 8 32} & 0x40)?(0x20, 0x30) could be further simplified, however expr_simp() doesn't seem to contain such pass. Am I missing something please?

nofiv avatar Aug 31 '21 20:08 nofiv

Hi @nofiv You are right: we may add a simplification here. Moreover this simplification seems quite "generic" so it's interesting to add it to the engine. Do you want to try to do a PR or do you prefer I add it ?

serpilliere avatar Sep 04 '21 03:09 serpilliere

Hello @serpilliere , I will try to do the PR

nofiv avatar Sep 04 '21 06:09 nofiv

In fact it seems I have missing #1347 I totally missed it from the submitted PR.

It seams that it's exactly what you requested right?

serpilliere avatar Sep 06 '21 06:09 serpilliere

Oh, great. Yes, that's exactly what I wanted

nofiv avatar Sep 06 '21 07:09 nofiv