shine icon indicating copy to clipboard operation
shine copied to clipboard

Handle client mount when mount point is a symlink

Open degremont opened this issue 14 years ago • 4 comments

When a symlink exists at configured client's mount_path, shine mounts the client after symlink resolution. This is not a good behaviour and shine should either:

  • print a warning, remove the symlink and mount the client
  • print an error message and abort

In general, assert that the mount point exists and is a directory.

Reported by: thiell

degremont avatar Mar 08 '10 13:03 degremont

        status
            changed from new to accepted
        
      
    

Workaround for Fedora13 (similar on RHEL6):

$ diff -u /lib/udev/rules.d/10-dm.rules /tmp/10-dm.rules --- /lib/udev/rules.d/10-dm.rules 2010-02-16 02:24:22.000000000 +0100 +++ /tmp/10-dm.rules 2010-08-27 10:32:52.675559452 +0200 @@ -77,7 +77,7 @@

possible future changes.

ENV{DM_UDEV_RULES_VSN}="1" -ENV{DM_UDEV_DISABLE_DM_RULES_FLAG}!="1", ENV{DM_NAME}=="?", SYMLINK+="mapper/$env{DM_NAME}" +ENV{DM_UDEV_DISABLE_DM_RULES_FLAG}!="1", ENV{DM_NAME}=="?", NAME+="mapper/$env{DM_NAME}"

We have to ignore further rule application for inappropriate events

and devices. But still send the notification if cookie exists.

Original comment by: thiell

degremont avatar Aug 27 '10 08:08 degremont

  • Description has changed:

Diff:




  • Milestone: 1.3 --> 1.4
  • Resolution: -->

Original comment by: degremont

degremont avatar Oct 10 '13 08:10 degremont

  • Milestone: 1.4 --> 1.5

Original comment by: degremont

degremont avatar Apr 30 '15 09:04 degremont

  • Milestone: 1.5 --> 1.6

Original comment by: degremont

degremont avatar May 24 '17 13:05 degremont