robinhood icon indicating copy to clipboard operation
robinhood copied to clipboard

lustre_tools.c: protect againt IOC_MDC_GETFILEINFO_V1 redefinition

Open cedeyn opened this issue 1 year ago • 2 comments

With lustre-2.15, IOC_MDC_GETFILEINFO_V1 is already declared in header file. This patch avoid compilation issue against more recent lustre version.

cedeyn avatar Nov 15 '23 09:11 cedeyn

I was thinking defining something unique. Like RH_IOC_MDC_GETFILEINFO_V1 to avoid the repeat of name clash which happened when lustre used the same name. We deleted the whole section as we knew it was not the old version. However, this approach is good too.

It seems a patch already exists with the same idea :) https://review.gerrithub.io/c/cea-hpc/robinhood/+/541134

It should be merged soon.

cedeyn avatar Nov 28 '23 10:11 cedeyn

I was thinking defining something unique. Like RH_IOC_MDC_GETFILEINFO_V1 to avoid the repeat of name clash which happened when lustre used the same name. We deleted the whole section as we knew it was not the old version. However, this approach is good too.

It seems a patch already exists with the same idea :) https://review.gerrithub.io/c/cea-hpc/robinhood/+/541134

It should be merged soon.

Thanks for letting me know. I agree with you. This is imporant and should be merged quickly.

arshad512 avatar Nov 28 '23 11:11 arshad512

Thank you for the contribution. A duplicate patch was landed to master: 7584c4f5ae058e0c7c322228bc8ee3c2fd375f1f

tl-cea avatar Aug 29 '24 13:08 tl-cea