clustershell icon indicating copy to clipboard operation
clustershell copied to clipboard

Incoherency between Worker and subclasses interfaces.

Open thiell opened this issue 12 years ago • 5 comments

Several functional aspect are either not present in all Worker subclasses, or named differently. For example, consider SimpleWorker.retcode() and DistantWorker.iter_retcode(). Neither method are present in the Worker interface.

thiell avatar Mar 03 '12 16:03 thiell

[st-cea] DistantWorker.max_retcode() is missing also while Task.max_retcode() exists... need to work on this for 1.4 for more coherency

thiell avatar Mar 03 '12 16:03 thiell

[hdoreau] I would also suggest that worker.last_read() always return the same type. Currently, a tuple (node, result) is returned by worker Ssh instances and only a result string by WorkerSimple instances.

thiell avatar Mar 03 '12 16:03 thiell

[ad-cea] I'm also adding Worker.num_timeout() which exist in DistantWorker but not in LocalWorker and should be put in Worker base class.

thiell avatar Mar 03 '12 16:03 thiell

[st-cea] ''bump''

thiell avatar Mar 03 '12 16:03 thiell

[st-cea] Forked ticket #137 to deal with Worker.current_* variables available since [milestone:1.4.1].

thiell avatar Mar 03 '12 16:03 thiell