notification-api
notification-api copied to clipboard
We want to save the reply_to_email_addresses in the cache
Summary | Résumé
We are not currently storing the reply_to_email_addresses which is a field on the Service model, to show up when we retrieve the Service from the cache. This meant that the reply_to_address was empty for the end user which is incorrect
Two parts:
- The service gets added to the cache when the admin gets loaded - we needed to change the model Schema so we send the reply_to_email_addresses to the admin
- We need to change the model to_json, so we might appropriately set the reply_to_email_addresses as a ServiceReplytoEmail model
Testing:
[ ] Set the reply_to_email_address [ ] Stay on the main branch: Send an email using the csv method - it will send an email WITHOUT the reply-to set [ ] Switch to this branch: Send an email using the csv method - it will send an email WITH the reply-to set
Example:
Related Issues | Cartes liées
- https://app.zenhub.com/workspaces/notify-planning-614b3ad91bc2030015ed22f5/issues/gh/cds-snc/notification-planning/1633
Reviewer checklist | Liste de vérification du réviseur
- [x] This PR does not break existing functionality.
- [x] This PR does not violate GCNotify's privacy policies.
- [x] This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
- [x] This PR does not significantly alter performance.
- [ ] Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).
⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.