notification-api icon indicating copy to clipboard operation
notification-api copied to clipboard

Add callback failure warning email

Open whabanks opened this issue 8 months ago • 0 comments

Summary | Résumé

This PR adds the groundwork for sending a warning email to service owners when their callback service is not working correctly.

The actual email sending based on threshold is not yet implemented. It is non-trivial to ensure that we don't spam users with emails every time a retried callback reaches the max retries of 5. For the time being we will simply monitor how frequently this occurs while the remaining work is completed.

Related Issues | Cartes liées

  • https://github.com/cds-snc/notification-terraform/pull/1352
  • https://github.com/cds-snc/notification-admin/pull/1855

Test instructions | Instructions pour tester la modification

TODO: Fill in test instructions for the reviewer.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • [ ] This PR does not break existing functionality.
  • [ ] This PR does not violate GCNotify's privacy policies.
  • [ ] This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • [ ] This PR does not significantly alter performance.
  • [ ] Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

whabanks avatar Jun 04 '24 21:06 whabanks