gcds-components icon indicating copy to clipboard operation
gcds-components copied to clipboard

feat: New gcds-notice component

Open ethanWallace opened this issue 1 year ago • 1 comments

Summary | Résumé

The notice is a prominent message to draw attention to important information or change.

<gcds-notice
  type=""
  notice-title=""
>
  <slot></slot>
</gcds-notice>

Requires tokens from https://github.com/cds-snc/gcds-tokens/pull/330. (Merged and installed)

ethanWallace avatar Aug 27 '24 19:08 ethanWallace

I have one small suggestion for the code to display the icons. I know we don't have the tokens yet so I'll review again once we have that in place. At the moment I don't see the lines on the icon, I'm guessing we need the tokens for that

@daine Would you be able to test with the tokens package linked? It helps identify if a mistake snuck through in the token package before it is published

ethanWallace avatar Oct 02 '24 12:10 ethanWallace

Blocked from merge by #963. Probably also needs a Publish ticket if we don't have one yet.

daine avatar Nov 19 '24 18:11 daine

To address https://github.com/cds-snc/design-gc-conception/issues/1283, new tokens have been added and will need to be published before this can be merged. https://github.com/cds-snc/gcds-tokens/pull/351

ethanWallace avatar Dec 10 '24 13:12 ethanWallace