gcds-components icon indicating copy to clipboard operation
gcds-components copied to clipboard

Design: Add visited state to Link

Open adorayi opened this issue 1 year ago • 5 comments

Summary: Update design of the link component to include a visited state, to align with Canada.ca. Design on component branch and push to main Figma file when approved.

Acceptance Criteria

  • [x] Link visited state has colour: #7532B8
  • [x] Link has value: Visited within property: State

Definition of done

  • [x] EN component is ready for merge
  • [x] FR component is ready for merge
  • [x] Update #572 (dev ticket) with link to design
  • [x] Review and update requirements doc with developer (if applicable)

Deliverables

Dev impact

Yes - Add visited link state to code #572

adorayi avatar Jun 25 '24 15:06 adorayi

Would the visited state apply to all link component instances or not.

adorayi avatar Jul 03 '24 15:07 adorayi

@adorayi 'push to main Figma when approved' - who's to approve? How do we take into consider what has transpired with the incidents?

realdylanzheng avatar Jul 24 '24 04:07 realdylanzheng

@realdylanzheng as long as other designers have reviewed and it's been shown to devs for feedback as well it can be pushed.

adorayi avatar Jul 31 '24 16:07 adorayi

Note: after talking to @realdylanzheng we decided to change the colour from #7834BC to #7532B8 to keep a minimum 7:1 colour contrast ratio that we ensure for all other 700 and above colour tokens.

melaniebmn avatar Jul 31 '24 18:07 melaniebmn

@realdylanzheng can we add the new purple colour to the "Styles" page in Figma as well to make sure we keep track of all of our colours there as well?

melaniebmn avatar Jul 31 '24 21:07 melaniebmn