gcds-components icon indicating copy to clipboard operation
gcds-components copied to clipboard

bug: <gcds-topic-menu> doesn't look the between FR and EN

Open gcharest opened this issue 1 year ago • 2 comments

Prerequisites

GC Design System Components Package and Version

[email protected]

Current Behavior

The collapsed French button for the component is narrower and uses more vertical space than the English version.

image image

Expected Behavior

They should be the exact same width and height and the chevron should be on the same line.

System Info

The behaviour is observed on:
- Chrome 125.0.6422.61
- Firefox 126.0 (64-bit)
- Safari 17.5

Using macOS 14.5 on Intel MacBook Pro

Steps to Reproduce

  1. Visit the links to the components : https://design-system.alpha.canada.ca/en/components/theme-and-topic-menu/design/
  2. Scroll down to the menu button
  3. Toggle language switch
  4. Scroll down to the menu button

Code Reproduction URL

No response

Additional Information

No response

gcharest avatar May 21 '24 23:05 gcharest

Hi Guillaume, thank you for the bug report!

We fixed the issue in this PR, and it will go live with our next package release. Thank you so much for reporting this!

melaniebmn avatar May 24 '24 02:05 melaniebmn

Thanks @melaniebmn ! I'll have a look at v0.22.0

I can also confirm that the issue wasn't present on v0.20.0 as I've been testing on various versions to see when the difference happened.

gcharest avatar May 25 '24 02:05 gcharest

Hey @gcharest, the bug was fixed yesterday with the version 0.22.1 release. Here is the changelog for the change.

Closing the issue for now, but please let us know if it's still happening for you after upgrading to the newest version.

melaniebmn avatar May 28 '24 16:05 melaniebmn