cdQA icon indicating copy to clipboard operation
cdQA copied to clipboard

Published 20 hours ago • verified publisher icon cdqa-suite

where is 'closest_docs_indices' variable created in retriever_sklearn.py?

Open yui-py opened this issue 5 years ago • 1 comments

Hello, I think a runtime error will occur. https://github.com/cdqa-suite/cdQA/blob/ea3aacf01448ecaba7b1c46091fe2b0e96accd73/cdqa/retriever/retriever_sklearn.py#L68

yui-py avatar Dec 09 '19 11:12 yui-py

Hi,

Thanks for pointing that. Actually we forgot to delete the block inside if verbose:. We had it in one of our preliminary versions but It doesn't make sense to keep it anymore.

I will be fixing it and opening a PR.

andrelmfarias avatar Dec 10 '19 09:12 andrelmfarias