mack icon indicating copy to clipboard operation
mack copied to clipboard

Swap to using audiotags for better compatibility

Open Ralim opened this issue 2 years ago • 6 comments

Hello 👋🏼 , I wanted to use this on FLAC files and it didnt yet work. I've done this base pass conversion over to audiotags. It seems to work nicely for me here. However audiotags doesnt support the comment field so not sure how to handle the filter for fixer_is_blacklisted. Would love your comments on how you would prefer to move forward for using it. Looking in the trait AudioTagEdit; there is no nicely exposed option for us to use.

Would close #36

Ralim avatar Jul 20 '23 01:07 Ralim

Hey! I actually added comment support to audiotags in preparation for this a few months ago, but there has been no release since: https://github.com/TianyiShi2001/audiotags/commit/b6b3df18c941f4f4ed575b5a09273135edb12a33

So the first step would be to have them do a release. Thanks for looking at this! :-)

cdown avatar Jul 25 '23 00:07 cdown

Ah well then that would be excellent. Should you/me/both of us ask for a release over there? Happy to update this once we get a release 😁

Ralim avatar Jul 25 '23 02:07 Ralim

Looks like a release is close: https://github.com/TianyiShi2001/audiotags/pull/40

cdown avatar Dec 02 '23 20:12 cdown

fyi the release happened

pinkforest avatar Feb 22 '24 10:02 pinkforest

bump also want to use this one flac

Bide-UK avatar Jun 12 '24 09:06 Bide-UK

I've updated the PR to use the latest audiotags release and comments. @cdown Would appreciate a review when you have time

Ralim avatar Jul 25 '24 22:07 Ralim