cdown
Migrate to AUR API v5
This migration also includes the following changes:
- base class of Package has been changed from namedtuple to dataclass, which forces python>=3.7. New AUR API has different set of fields for search and info (first one missing list fields), in order to declare optional fields dataclass features have been used. Also some namedtuple methods have been ported (it changes _fields property to cllassmethod though)
- search method now have optional argument search_by
- removed python2 support
- dependencies have been updated to actual ranges
This MR also closes #28. Closes #27
I've also updated test cases, so they all passed for me with new models.
There is also one more breaking change - previously license property has been declared as string, which actually leads to interesting effects:
https://aur.archlinux.org/rpc.php?type=multiinfo&arg=brave-bin https://aur.archlinux.org/rpc.php?type=multiinfo&arg=brave-bin&v=5
In new version it is just list of strings
Wow! First of all, thanks for working on this.
Second of all, I must confess this project is absolutely dead. In fact it's so dead I'd actually forgotten I'd written it. Your changes look excellent, although I didn't look through them in super close detail.
So I have an alternative proposal: maybe you or someone you know would like to take over ownership of this codebase? Clearly you are capable of doing an excellent job here. Sorry to land that on you out of nowhere, but I am clearly not a very good maintainer having done absolutely nothing for 5 years. :-)
If you'd rather not do that, happy to look over it in more detail and merge it, but it might take a little bit for me to get familiar with how things work again.
I would love to see this continue to be maintained as I have been using it as a simple interface for an AUR pipeline I've been building.
@cdown additionally, it looks like a PyPi project transfer would be needed: https://www.python.org/dev/peps/pep-0541/#how-to-request-a-name-transfer
@jamincollins do you have your version of the aur python library published somewhere?
I do not, but would be willing to adopt the packages and take over repository maintenance.
Would rather not start another package distribution channel/mechanism.
@jamincollins alright, I've now tried to contact him over email in hope, that he'll follow the necessary steps given to help
No need to get my attention over e-mail, I'm watching here, just I have a finite amount of time to spend on personal open source work.
Happy to transfer the ownership, but I'd prefer to give @arcan1s first dibs since he clearly has a significant understanding of the project from this PR.
That's dependent on reviewing it, which I haven't had time to do yet. If I'm going to merge it, I have to take responsibility for the contents as much as the author.
@cdown oh sorry for ignoring this pull request update :smile: well I don't mind to take ownership, but unfortunately don't really know how does transfer work (well if we are talking about repository it is fine to manage just fork, but pypi package requires transfer at least?)
@cdown @arcan1s any news on migrating the ownership of the pypi page? I actually forgot the remote changed. Where arcan1s's repo works and this does not.
@arcan1s Would also be nice to enable issues to become the new upstream. @cdown this repo should be archived and the new one should be referenced.
The main issue is the pypi project transferring. I think it can be done by something like https://discuss.python.org/t/transferring-a-pypi-name-to-someone-else/7196/2 (sorry I never did it before), my username there is arcanis (https://pypi.org/user/arcanis/).
Repository transfer is also possible (and I think it would be good also as github will persist redirects and so on) and can be done on project settings page.
Oh and also there is rtd page in which it is possible to at least add maintainer