robrank icon indicating copy to clipboard operation
robrank copied to clipboard

Name 'os' is not defined.

Open michaeltian108 opened this issue 3 years ago • 2 comments

Hi, I'm trying to do a defensive training on resnet18 without SPC2 term so that I can futher alter the loss function. However, I'm constantly encountering with the following problem, but I have no clue about where could possbily be wrong. image

Thanks!

michaeltian108 avatar Dec 02 '21 12:12 michaeltian108

Thank you for reporting this issue. To build this work upon the ICML work, SPC-2 batch is used by default. The ttripletN config is inherited from the old implementation, and hence may suffer from some unfixed bugs. I may look into it in the future and fix the problem, and any patch will be appreciated as well.

cdluminate avatar Dec 15 '21 02:12 cdluminate

BTW, as mentioned in the ICML20 paper "revisiting ...", SPC-2 batch reaches better result than simple random batches. So do we have a reason to seriously support the old function?

cdluminate avatar Dec 15 '21 02:12 cdluminate