construct-hub-webapp icon indicating copy to clipboard operation
construct-hub-webapp copied to clipboard

Live deployment of PR's

Open iliapolo opened this issue 4 years ago • 2 comments

Changes to the webapp usually result in some visual changes that we want to inspect and provide feedback on.

Right now, we do this by capturing snapshots on the changes from our local development environments. Apart from being a bit risky (maybe the snapshot was taken from some stale code..?), it also doesn't allow reviewers to properly evaluate the changes.

We could leverage GitHub Deployment and deploy a live environment for every PR, this deployment will post a URL in the status check that can be navigated to and inspected.

To reduce costs or un-necessary deployments, we could make it so deployments only happen for PR's labeled with some label, added by the author.

iliapolo avatar Oct 10 '21 11:10 iliapolo

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon.

github-actions[bot] avatar Dec 10 '21 01:12 github-actions[bot]

Keep

iliapolo avatar Dec 16 '21 12:12 iliapolo