cdk-monitoring-constructs
cdk-monitoring-constructs copied to clipboard
cdklabs
Data Table Support in GraphWidgetType
Feature scope
Custom
Describe your suggested feature
It looks like the data table type is missing from GraphWidgetType. I'm not sure if the data table is a recent widget that CW added or if there hasn't been a use case for it.
https://github.com/cdklabs/cdk-monitoring-constructs/blob/598dea1bd09df69d7d8dbc070ae9728f8629bd67/lib/common/widget/types.ts#L9-L15
It doesn't seem to be too hard to add. I can probably do a PR. I just wanted to confirm the scope first.
TableWidget was added in cdk-lib 5 months ago, so it's relatively recent.
https://github.com/aws/aws-cdk/commit/4599aa3c4502e5e5e5fb7434913f7ce9a6468547
Looks like we'd need to bump to minimum [email protected] to get TableWidget, but we're currently at min 2.112.0. Bumping that would be a breaking change/major version bump, or temporarily maintaining a copy of it.
I'm not particularly a fan of either right now unless we wanted to bring in other new features from newer aws-cdk-lib versions too. Any thoughts from your end?
That's fair. I don't have a strong need for it; I was just playing around with different widgets.
Now that the dependency on aws-cdk-lib has been bumped, we should be able to do this, right? I can take a stab at making the change; I just want to confirm if there are any other blockers. @echeung-amzn
Yes, this should technically be feasible at this point. Feel free to take a stab at it!