cdk-ecr-deployment icon indicating copy to clipboard operation
cdk-ecr-deployment copied to clipboard

feat: added ability to change the architecture of the lambda

Open TheGoatedDev opened this issue 2 years ago • 4 comments
trafficstars

Added as of the issues when deploying on a X86_64 Lambda Function with a ARM64 DockerImage.

TheGoatedDev avatar Oct 06 '23 16:10 TheGoatedDev

Please fix the build error firstly

wchaws avatar Nov 03 '23 02:11 wchaws

@TheGoatedDev would you mind addressing the PR comments? would appreciate if this landed

uncledru avatar Mar 15 '24 15:03 uncledru

Hi @uncledru, Sorry that I haven't been able to be able to get back to fixing this issue, I don't have much time spare and the personal need for this feature is no longer a top-priority, you are free to fix the build and I will happily do the PR Reviews so that we can move this forward, if you do it on my fork.

TheGoatedDev avatar Mar 15 '24 16:03 TheGoatedDev

Hi @uncledru, Sorry that I haven't been able to be able to get back to fixing this issue, I don't have much time spare and the personal need for this feature is no longer a top-priority, you are free to fix the build and I will happily do the PR Reviews so that we can move this forward, if you do it on my fork.

After digging a bit deeper, I realized I needed a slightly different change. Would appreciate a review if you have a moment: https://github.com/cdklabs/cdk-ecr-deployment/pull/570

uncledru avatar Mar 15 '24 20:03 uncledru