cdk-ecr-deployment icon indicating copy to clipboard operation
cdk-ecr-deployment copied to clipboard

Published 20 hours ago • verified publisher icon cdklabs

fix: bump allowed major version

Open Hi-Fi opened this issue 3 years ago • 3 comments
trafficstars

Fixes releasing of main branch which bumps major version

Hi-Fi avatar Sep 12 '22 17:09 Hi-Fi

@wchaws This is needed for release, or then rewriting the history in main to keep major in v2.

Hi-Fi avatar Sep 12 '22 17:09 Hi-Fi

This is needed for release, or then rewriting the history in main to keep major in v2.

But this will leave a version of v3.0.0 in npm.

wchaws avatar Sep 13 '22 12:09 wchaws

This is needed for release, or then rewriting the history in main to keep major in v2.

But this will leave a version of v3.0.0 in npm.

I think there's no 3.0.0 in npm as action failed before publishing (https://www.npmjs.com/package/cdk-ecr-deployment). So if history is rewritten and Breaking change removed, 2.x version is released including break in the credential usage.

Hi-Fi avatar Sep 13 '22 12:09 Hi-Fi

Change was reverted. We stay on the v2 line for now.

mrgrain avatar Jun 15 '23 13:06 mrgrain