cdk8s-plus icon indicating copy to clipboard operation
cdk8s-plus copied to clipboard

Allow specifying multiple `dockerRegistryAuth`s.

Open HamishWHC opened this issue 1 year ago • 1 comments

Description of the feature or enhancement:

Currently, only a single secret for registry auth is accepted when creating a pod/deployment. The K8s spec allows for mutiple to be specified, so that we can pull images from multiple sources if needed.

Use Case:

I need my pods to include a container from my own registry plus a sidecar from a public registry.

Proposed Solution:

Unsure how best to make a change like this - not all the supported languages allow for args to be multiple types like in TS or Python AFAIK (in those languages you could just allow ISecret | ISecret[]/Python equivalent to avoid breaking existing code), so potentially adding a new property? Seems clunky though.

Other:

  • [ ] :wave: I may be able to implement this feature request
  • [x] :warning: This feature might incur a breaking change

This is a :rocket: Feature Request

HamishWHC avatar Jan 06 '24 23:01 HamishWHC