irssi-xmpp
irssi-xmpp copied to clipboard
cdidier
Feature Request: Message Carbons and OMEMO
Now that everybody has a smartphone in addition to a more traditional computer, for example with Android and the excellent Conversations app, there are two things I miss in irssi-xmpp:
-
Message Carbons (XEP-0280), so I get to log / follow / finish off a discussion I started on my mobile while on the move on a proper keyboard. This has been implemented by singpolyma, and seems to work fine for me so far: https://github.com/singpolyma/irssi-xmpp/commit/563b255bafa981c357a6cde940b177342b8032b5 (there's a lot of work on xmpp-pgp in that repo, which I haven't gotten around to use and test much apart from including it in the Debian package, but this one is a killer feature IMHO). This is probably as simple as a cherry-pick, and I'm happy to prepare a pull request if you prefer?
-
OMEMO (https://conversations.im/omemo/), an adaptation of TestSecure's Axolotl for XMPP. There's https://github.com/WhisperSystems/libaxolotl-c that perhaps can be built upon, but I'm not sure any of the XMPP specifics have been implemented in C yet, and the XEPs are still in draft status. Nevertheless this would be an awesome thing to have!
-
The implementation of singpolyma looks good, but there is a few coding style fixes to do (to be coherent with the rest of the project) and the copyright header is missing.
-
The XEP for OMEMO should not be too difficult to implement (https://conversations.im/xeps/multi-end.html). But irssi-xmpp is GPLv2 only and libaxolotl-c is GPLv3 only, so they are incompatible... irssi-xmpp needs to be relicensed to GPLv2 and above. This is not a problem, as I agree to relicense it, but this is time consuming. If someone is willing to implement such feature in irssi-xmpp, i'll move forward with the licensing.
when you consider carbon copy maybe also consider MAM. there are already some implementations for servers and other clients.
Omemo is official XEP-0384 since December 2016. You can check other implementation at https://omemo.top/
@cdidier I will clean up my carbons to include a copyright header and submit a pull request soon :)
There is irssi-otr but OMEMO support would be nice too. For channels fishlim implements the outdated blowfish cipher.
Am I crazy or does this already happen (sometimes) for others?
I swear that it used to work for a while, I could see all messages in and out on all devices including irssi-xmpp - but again its not working.
(One more in the queue for an update...)
I'd also love to see this implemented!
Is there any way we can help to move this forward?
@MalakymR the official Debian package includes my patches to implement carbons (see #25) so maybe you were using that for awhile and that's why you had it?
I compiled it myself some time back with various PR patches so it was probably that, and im using the arch -git package which may have had it at some point and then dropped it? Doesn't seem so.
Either way it looks like your work is what we want and I hope to see it included soon or an explanation of why not.
two years ago I started some work on this in a fork of the pidgin module at https://github.com/ailin-nemui/lurch in case you feel like you can help
@ailin-nemui: Nice! Can you compare with main lurch and create a PR with your improvements?
Have you looked changes from https://github.com/gkdr/lurch/commits/master ? Since "Commits on Jun 6, 2018" :)
lurch is for pidgin. my fork is a port of lurch from pidgin to irssi. That's why there are no changes to submit to gkdr. If anything, help would be needed to integrate updates from gkdr to my fork. Also my port is not finished/working yet and needs help. I already opened #52 but that's just a small part of getting all to work