Bitcoin-mining-proxy icon indicating copy to clipboard operation
Bitcoin-mining-proxy copied to clipboard

Published 20 hours ago • verified publisher icon cdhowie

Attempting to edit a pool results in "Pool not found."

Open rscullin opened this issue 13 years ago • 6 comments

Attempting to edit a pool in the latest git commit ( 81b3ce1f9b492100ec847e2d2f500bf46f5ac0d7 ) results in the error "Pool not found."

This seems to be because of a missing GROUP BY clause in the SQL query starting on line 96 in pool.inc.php, which throws a MySQL error. Adding GROUP BY wp.worker_id after the WHERE clause appears to fix this.

rscullin avatar May 14 '11 07:05 rscullin

I'm wondering if this is still an issue as Ii am not able to duplicate it and can edit pools fine on my end?

wyze avatar Jun 23 '11 15:06 wyze

@wyze, this issue is specific to some versions of MySQL and not others. Newer versions seem to infer the GROUP BY clause, while older versions require it explicitly.

cdhowie avatar Jun 23 '11 15:06 cdhowie

Doesn't seem to happen to me on MySQL 5.1.56. FYI.

edgeman16 avatar Jun 23 '11 16:06 edgeman16

Why not just add this in there then? It won't hurt newer versions of MySQL and will fix older versions. Wouldn't take a performance hit and a very small and simple change to the code.

wyze avatar Jun 23 '11 19:06 wyze

The version of MySQL that's giving me issues is: mysql Ver 14.12 Distrib 5.0.51a, for debian-linux-gnu (i486) using readline 5.2

rscullin avatar Jun 27 '11 05:06 rscullin

I have pushed 83d0672, which might resolve this issue. Can those of you who have had trouble with this query pull down the latest and try again?

cdhowie avatar Jun 28 '11 19:06 cdhowie