sig-events icon indicating copy to clipboard operation
sig-events copied to clipboard

SDK: Missing examples of sending events

Open m-linner-ericsson opened this issue 3 years ago • 5 comments

In the readme for the SDK we list examples of how to send events. The SDK does support more events than listed in the examples.

To resolve this issue add examples for sending the other event types.

m-linner-ericsson avatar Sep 07 '21 15:09 m-linner-ericsson

I would like to work on this.

nathannaveen avatar Sep 08 '21 01:09 nathannaveen

I was looking into this and noticed that taskrun events have examples for queued while the cli does not.

Which of these is correct, the example or the code?

go run main.go taskrun 
Emit TaskRun related CloudEvent

Usage:
  cde taskrun [command]

Available Commands:
  finished    Emit TaskRun Finished Event
  started     Emit TaskRun Started Event

Flags:
  -d, --data stringToString   Task Run's Data (default [])
  -h, --help                  help for taskrun
  -i, --id string             Task Run Id
  -n, --name string           Task Run's Name
  -p, --pipelineid string     Task Run's Pipeline Id

Global Flags:
      --config string   config file (default is $HOME/.cde.yaml)

Use "cde taskrun [command] --help" for more information about a command.

nathannaveen avatar Sep 08 '21 01:09 nathannaveen

@nathan-415 There were some inconsistencies that were fixed by https://github.com/cdfoundation/sig-events/pull/84 (merged the 9:th) could this answer your questions?

m-linner-ericsson avatar Sep 10 '21 07:09 m-linner-ericsson

Is this issue still valid, @m-linner-ericsson, @nathannaveen , @afrittoli ? If so, it should be re-created in the cdevents/sdk-go repo

e-backmark-ericsson avatar Sep 02 '22 07:09 e-backmark-ericsson

If we solve https://github.com/cdfoundation/sig-events/issues/129 this would not be an issue any longer.

m-linner-ericsson avatar Sep 14 '22 09:09 m-linner-ericsson